From: | Jon Nelson <jnelson+pgsql(at)jamponi(dot)net> |
---|---|
To: | stefan(at)drees(dot)name |
Cc: | Greg Smith <greg(at)2ndquadrant(dot)com>, Merlin Moncure <mmoncure(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: fallocate / posix_fallocate for new WAL file creation (etc...) |
Date: | 2013-06-11 17:52:25 |
Message-ID: | CAKuK5J34ecGN_JN_pgNAx9CCH2s=Oc7Faj0k8hwEd=pct88RBg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Jun 11, 2013 at 12:49 PM, Stefan Drees <stefan(at)drees(dot)name> wrote:
> On 2013-06-11 19:45 CEST, Greg Smith wrote:
>>
>> On 6/11/13 12:22 PM, Merlin Moncure wrote:
>>
>>> Personally I think this patch should go in regardless -- the concerns
>>> made IMNSHO are specious.
>>
>>
>> That's nice, but we have this process for validating whether features go
>> in or not that relies on review instead of opinions.
>>
> ;-) that's why I played with the test_fallocate.c, as it was easy to do and
> I understood, the author (of the patch) wanted to trigger some reviews ... I
> do not (yet) know anything about the core codes, so I leave this to the
> hackers. My review result was, that with newer gcc's you should specify an
> open mode flag as third argument of the fopen call, as only with the test
> tool nothing important found.
If you change line 68 to read:
fd = open(filename, O_CREAT | O_EXCL | O_WRONLY, 0600);
then it should work just fine (assuming you have not already done so).
--
Jon
From | Date | Subject | |
---|---|---|---|
Next Message | Teodor Sigaev | 2013-06-11 17:58:38 | Re: SPGist "triple parity" concept doesn't work |
Previous Message | Stefan Drees | 2013-06-11 17:49:55 | Re: fallocate / posix_fallocate for new WAL file creation (etc...) |