| From: | Stefan Drees <stefan(at)drees(dot)name> |
|---|---|
| To: | Greg Smith <greg(at)2ndQuadrant(dot)com> |
| Cc: | Merlin Moncure <mmoncure(at)gmail(dot)com>, Jon Nelson <jnelson+pgsql(at)jamponi(dot)net>, Noah Misch <noah(at)leadboat(dot)com>, Andres Freund <andres(at)2ndQuadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: fallocate / posix_fallocate for new WAL file creation (etc...) |
| Date: | 2013-06-11 17:49:55 |
| Message-ID: | 51B76343.20105@drees.name |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2013-06-11 19:45 CEST, Greg Smith wrote:
> On 6/11/13 12:22 PM, Merlin Moncure wrote:
>
>> Personally I think this patch should go in regardless -- the concerns
>> made IMNSHO are specious.
>
> That's nice, but we have this process for validating whether features go
> in or not that relies on review instead of opinions.
>
;-) that's why I played with the test_fallocate.c, as it was easy to do
and I understood, the author (of the patch) wanted to trigger some
reviews ... I do not (yet) know anything about the core codes, so I
leave this to the hackers. My review result was, that with newer gcc's
you should specify an open mode flag as third argument of the fopen
call, as only with the test tool nothing important found.
Stefan.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jon Nelson | 2013-06-11 17:52:25 | Re: fallocate / posix_fallocate for new WAL file creation (etc...) |
| Previous Message | Greg Smith | 2013-06-11 17:45:15 | Re: fallocate / posix_fallocate for new WAL file creation (etc...) |