Re: [pgAdmin][RM5569] [SQL] Bad display of tables storage parameters in the "SQL" tab (correction of bug #5398 not complete)

Hi Akshay,

Changes for nodes.sql of EPAS where missed out due to which failures were
undetected on EPAS as test cases were only included for pg, now those are
added for epas as well.

Also, newly added changes are:
Added comment & owner of partition leaf to be viewable on its parent table
SQL.

On Sat, Jul 11, 2020 at 8:40 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Rahul
>
> Reverting the patch.
>
> Have you run the RESQL test cases for all the PG/EPAS server? Jenkin's
> build failed on PG 11 and RESQL test cases are not implemented for EPAS at
> all.
> @Rahul Shirsat <rahul(dot)shirsat(at)enterprisedb(dot)com> please make sure before
> sending the patch.
> @Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> please run as a part of
> the review process.
>
> Fixes needed:
>
> - Rename the folder "partitions/tests/pg/11_plus" to
> "partitions/tests/pg/12_plus" as OID and default tablespace not available
> from PG/EPAS 12.
>
> Yes, this is fixed, as there is not much difference for 10 & 11 for
tables, so 12_plus is the new change.

>
> - Remove extra space from table/sql/11_plus/create.sql to fix RESQL
> test cases.
>
> This is fixed.

>
> - On EPAS server facing "autovacuum_enabled" key error when we create
> a Partitioned Table and click on the SQL tab.
>
> This is fixed now.

>
> - Make sure if you change any SQL file similar changes need to be done
> for EPAS and other version-specific folder.
>
> That was missed out, now it is fixed.

>
> On Sat, Jul 11, 2020 at 5:01 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Thanks, patch applied.
>>
>> On Fri, Jul 10, 2020 at 6:16 PM Khushboo Vashi <
>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> I have fixed the issue and also reviewed the patch.
>>> It looks good to me apart from the written RE-SQL test cases that don't
>>> test the SQL storage params (which will be added with the different RM as
>>> per our last conversation).
>>>
>>> Thanks,
>>> Khushboo
>>>
>>> On Fri, Jul 10, 2020 at 5:31 PM Khushboo Vashi <
>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Rahul,
>>>>
>>>> I couldn't continue my review as I got an error on update.
>>>>
>>>> [image: Partitioned_sql_update.png]
>>>>
>>>> Thanks,
>>>> Khushboo
>>>>
>>>> On Fri, Jul 10, 2020 at 5:19 PM Rahul Shirsat <
>>>> rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi Khushboo,
>>>>>
>>>>> I had already corrected the patch as soon as I saw your mail, but
>>>>> couldn't send you as I went out on an urgency. Now sending it.
>>>>>
>>>>> On Fri, Jul 10, 2020 at 10:25 AM Khushboo Vashi <
>>>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>> Hi Rahul,
>>>>>>
>>>>>> I am getting errors while applying the patch, please rebase the patch
>>>>>> and send it again.
>>>>>>
>>>>>> Thanks,
>>>>>> Khushboo
>>>>>>
>>>>>> On Thu, Jul 9, 2020 at 1:25 PM Akshay Joshi <
>>>>>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>>>>>
>>>>>>> Hi Khushboo
>>>>>>>
>>>>>>> Can you please review it.
>>>>>>>
>>>>>>> On Wed, Jul 8, 2020 at 6:12 PM Rahul Shirsat <
>>>>>>> rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:
>>>>>>>
>>>>>>>> Hi Hackers,
>>>>>>>>
>>>>>>>> Following patch includes fix for :
>>>>>>>>
>>>>>>>> Storage parameters should be displayed in parent tables's SQL.
>>>>>>>>
>>>>>>>> As the code will be upgraded in feature #5649
>>>>>>>> <https://redmine.postgresql.org/issues/5649>, so only initial test
>>>>>>>> cases for pg 10, 11 are included in this patch, so later it can be
>>>>>>>> continued with the latest code.
>>>>>>>>
>>>>>>>> --
>>>>>>>> *Rahul Shirsat*
>>>>>>>> Software Engineer | EnterpriseDB Corporation.
>>>>>>>>
>>>>>>>> On Mon, Jul 6, 2020 at 2:27 PM Khushboo Vashi <
>>>>>>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>>>>>>
>>>>>>>>> Hi Rahul,
>>>>>>>>>
>>>>>>>>> - The storage parameters should be displayed in the parent table's
>>>>>>>>> SQL too
>>>>>>>>> - Please write test cases, preferably re-sql test cases
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> Khushboo
>>>>>>>>>
>>>>>>>>> On Mon, Jul 6, 2020 at 11:28 AM Akshay Joshi <
>>>>>>>>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>>>>>>>>
>>>>>>>>>> Hi Khushboo,
>>>>>>>>>>
>>>>>>>>>> Can you please review it.
>>>>>>>>>>
>>>>>>>>>> On Sat, Jul 4, 2020 at 1:45 AM Rahul Shirsat <
>>>>>>>>>> rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi Hackers,
>>>>>>>>>>>
>>>>>>>>>>> Please find the attached patch which fixes the issue related to
>>>>>>>>>>> the partition table with storage parameters.
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>> *Rahul Shirsat*
>>>>>>>>>>> Software Engineer | EnterpriseDB Corporation.
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> *Thanks & Regards*
>>>>>>>>>> *Akshay Joshi*
>>>>>>>>>>
>>>>>>>>>> *Sr. Software Architect*
>>>>>>>>>> *EnterpriseDB Software India Private Limited*
>>>>>>>>>> *Mobile: +91 976-788-8246*
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> *Rahul Shirsat*
>>>>>>>> Software Engineer | EnterpriseDB Corporation.
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> *Thanks & Regards*
>>>>>>> *Akshay Joshi*
>>>>>>>
>>>>>>> *Sr. Software Architect*
>>>>>>> *EnterpriseDB Software India Private Limited*
>>>>>>> *Mobile: +91 976-788-8246*
>>>>>>>
>>>>>>
>>>>>
>>>>> --
>>>>> *Rahul Shirsat*
>>>>> Software Engineer | EnterpriseDB Corporation.
>>>>>
>>>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

--
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.