From: | Ning Yu <nyu(at)pivotal(dot)io> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Paul Guo <pguo(at)pivotal(dot)io> |
Subject: | Re: Possible race condition in pg_mkdir_p()? |
Date: | 2019-07-31 04:48:48 |
Message-ID: | CAKmaiL0A5hL=sk9Cr=WmbaNkvp2_avYONhSoXGkHU_j1u3+OmQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jul 31, 2019 at 12:41 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Jul 31, 2019 at 12:26:30PM +0800, Ning Yu wrote:
> > Could I double confirm with you that you made a clean rebuild after
> > applying the patches? pg_mkdir_p() is compiled as part of libpgport.a,
> > and the postgres makefile will not relink the initdb binary
> > automatically, for myself I must 'make clean' and 'make' to ensure
> > initdb gets relinked.
>
> For any patch I test, I just do a "git clean -d -x -f" before building
> as I switch a lot across stable branches as well. It looks that you
> are right on this one though, I have just rebuilt from scratch and I
> don't see the failures anymore.
Cool, glad to know that it works.
Best Regards
Ning
> --
> Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Craig Ringer | 2019-07-31 05:08:12 | Re: tap tests driving the database via psql |
Previous Message | Michael Paquier | 2019-07-31 04:48:23 | Re: Possible race condition in pg_mkdir_p()? |