Re: Possible race condition in pg_mkdir_p()?

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Ning Yu <nyu(at)pivotal(dot)io>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Paul Guo <pguo(at)pivotal(dot)io>
Subject: Re: Possible race condition in pg_mkdir_p()?
Date: 2019-07-31 04:40:54
Message-ID: 20190731044054.GL1577@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 31, 2019 at 12:26:30PM +0800, Ning Yu wrote:
> Could I double confirm with you that you made a clean rebuild after
> applying the patches? pg_mkdir_p() is compiled as part of libpgport.a,
> and the postgres makefile will not relink the initdb binary
> automatically, for myself I must 'make clean' and 'make' to ensure
> initdb gets relinked.

For any patch I test, I just do a "git clean -d -x -f" before building
as I switch a lot across stable branches as well. It looks that you
are right on this one though, I have just rebuilt from scratch and I
don't see the failures anymore.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2019-07-31 04:43:26 Re: POC: Cleaning up orphaned files using undo logs
Previous Message Ning Yu 2019-07-31 04:35:02 Re: Possible race condition in pg_mkdir_p()?