Re: Database child node: Cast node patch

From: Priyanka Shendge <priyanka(dot)shendge(at)enterprisedb(dot)com>
To: Dave Page <dave(dot)page(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Kanchan Mohitey <kanchan(dot)mohitey(at)enterprisedb(dot)com>
Subject: Re: Database child node: Cast node patch
Date: 2016-10-04 08:01:50
Message-ID: CAKmZXFTv6rOMoktLiw-wWNaNzH6N0Z-3DxJm9+N5b5h6Q6y_8g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

I applied this patch on clean machine and executed testsuite only for
"cast" node, i did not face any issue.
When i tried to execute testsuite for all nodes, i get same output as you
mentioned above e-mail. (As few variable name
have changed later on in test_utils.py file and those are yet to change in
server and database API cases. So while importing
those variables its throwing import error.) Also, me and Navnath have
verified that this output is not related to setup.py changes.
(7175929cab984e070d15eb13625ab50459edf9ca)

Could you please try running testsuite only for cast node (python
regression/runtests.py --pkg browser.server_groups.servers.databases.casts)
and let me know if there are any issues.

Thank you.

On 3 October 2016 at 18:16, Dave Page <dave(dot)page(at)enterprisedb(dot)com> wrote:

> Hi
>
> On Wed, Sep 28, 2016 at 8:47 AM, Priyanka Shendge
> <priyanka(dot)shendge(at)enterprisedb(dot)com> wrote:
> > Hi Dave,
> >
> > Please find the attached patch for Cast node. (Changes required due to
> drop
> > objects functionality).
> >
> > To run test cases please enter following command:
> >
> > python regression/runtests.py --pkg
> > browser.server_groups.servers.databases.casts
> >
> > Let me know if any changes required.
>
> Whilst the tests pass, I get the following output immediately after
> the config database is created:
>
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name advanced_config_data
> route.py: line:73 cannot import name pickle_path
> route.py: line:73 cannot import name test_server_dict
> route.py: line:73 cannot import name test_server_dict
> route.py: line:73 cannot import name test_server_dict
> route.py: line:73 cannot import name test_server_dict
> route.py: line:73 cannot import name test_server_dict
> route.py: line:73 cannot import name test_server_dict
> route.py: line:73 cannot import name test_server_dict
> route.py: line:73 cannot import name test_server_dict
> route.py: line:73 cannot import name test_server_dict
> route.py: line:73 cannot import name test_server_dict
> route.py: line:73 cannot import name test_server_dict
> route.py: line:73 cannot import name test_server_dict
> route.py: line:73 cannot import name test_server_dict
>
> Perhaps this is related to the setup.py change I had to revert in
> 7175929cab984e070d15eb13625ab50459edf9ca?
>
> --
> Dave Page
> VP, Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>

--
Best,
Priyanka

EnterpriseDB Corporation
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-10-04 11:51:18 pgAdmin 4 commit: Optionally sign both the Mac app bundle and the disk
Previous Message Ashesh Vashi 2016-10-04 07:47:31 Re: Connection to the server has been lost