Re: Database child node: Cast node patch

From: Dave Page <dave(dot)page(at)enterprisedb(dot)com>
To: Priyanka Shendge <priyanka(dot)shendge(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Kanchan Mohitey <kanchan(dot)mohitey(at)enterprisedb(dot)com>
Subject: Re: Database child node: Cast node patch
Date: 2016-10-04 14:06:57
Message-ID: CA+OCxoyNR_mzGEEUqVXSPdvR-KFU91DoSg9hkyVX31SqVLJV3w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Tue, Oct 4, 2016 at 9:01 AM, Priyanka Shendge
<priyanka(dot)shendge(at)enterprisedb(dot)com> wrote:
> I applied this patch on clean machine and executed testsuite only for "cast"
> node, i did not face any issue.
> When i tried to execute testsuite for all nodes, i get same output as you
> mentioned above e-mail. (As few variable name
> have changed later on in test_utils.py file and those are yet to change in
> server and database API cases. So while importing
> those variables its throwing import error.) Also, me and Navnath have
> verified that this output is not related to setup.py changes.
> (7175929cab984e070d15eb13625ab50459edf9ca)
>
> Could you please try running testsuite only for cast node (python
> regression/runtests.py --pkg browser.server_groups.servers.databases.casts)
> and let me know if there are any issues.

No, I don't see the issue if I only run the cast tests.

I'm not sure how this helps though - I still see the problem if I run
all tests with the patch applied. If I revert the patch, it goes away.
Therefore it's definitely being triggered by the cast patch, if not,
caused by it.

--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2016-10-05 06:23:31 PATCH: To fix the issue where pgAdmin4 was not honouring ssl mode options (pgAdmin4)
Previous Message Dave Page 2016-10-04 13:48:59 pgAdmin 4 commit: pgAgent docs. Fixes #1824