| From: | Abhishek Chanda <abhishek(dot)becs(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Adding support for SSLKEYLOGFILE in the frontend |
| Date: | 2025-01-10 23:16:44 |
| Message-ID: | CAKiP-K-nG4Xzh-DGvT7Hgztw1WuV90uUK29_-z7Fe-a=EDtiEA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks, Daniel. Here is an updated patch with all previous changes,
added a simple connection test and another check to make sure file
mode is correct, and the env var fix. Please let me know if anything
needs to be changed. I tested this locally using meson running all TAP
tests, and also manually.
Thanks
Abhishek
On Fri, Jan 10, 2025 at 9:29 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 10 Jan 2025, at 04:59, Abhishek Chanda <abhishek(dot)becs(at)gmail(dot)com> wrote:
>
> Thanks for the new version.
>
> + {"sslkeylogfile", "SSLKEYLOGFILE",
> The env var should be PGSSLKEYLOGFILE with the PG prefix.
>
> > 3. Added docs and tests
>
> There is no test in the attached patch, did you write one but forgot to git add
> it before committing locally?
>
> --
> Daniel Gustafsson
>
--
Thanks and regards
Abhishek Chanda
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Add-support-for-dumping-SSL-keylog-to-a-file.patch | application/octet-stream | 8.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2025-01-10 23:17:23 | Re: Restore support for USE_ASSERT_CHECKING in extensions only |
| Previous Message | Melanie Plageman | 2025-01-10 23:09:24 | Re: Adjusting hash join memory limit to handle batch explosion |