Re: Draft for basic NUMA observability

From: Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>
To: Tomas Vondra <tomas(at)vondra(dot)me>
Cc: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Draft for basic NUMA observability
Date: 2025-04-04 17:07:12
Message-ID: CAKZiRmyxQvXp8LHBWyXXoD1iUWK8gNRVB1ZJSnoyc8gCi6JWBg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Apr 4, 2025 at 4:36 PM Tomas Vondra <tomas(at)vondra(dot)me> wrote:

Hi Tomas,

> Do you have any suggestions regarding the column names in the new view?
> I'm not sure I like node_id and page_num.

They actually look good to me. We've discussed earlier dropping
s/numa_//g for column names (after all views contain it already) so
they are fine in this regard.
There's also the question of consistency: (bufferid, page_num,
node_id) -- maybe should just drop "_" and that's it?
Well I would even possibly consider page_num -> ospagenumber, but that's ugly.

-J.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dimitrios Apostolou 2025-04-04 17:11:31 [PATCH] parallel pg_restore: move offset-building phase to before forking
Previous Message Dimitrios Apostolou 2025-04-04 16:55:44 Re: [PATCH v2] parallel pg_restore: avoid disk seeks when jumping short distance forward