Re: Windows pg_basebackup unable to create >2GB pg_wal.tar tarballs ("could not close file: Invalid argument" when creating pg_wal.tar of size ~ 2^31 bytes)

From: Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Dilip Kumar <dilip(dot)kumar(at)enterprisedb(dot)com>
Subject: Re: Windows pg_basebackup unable to create >2GB pg_wal.tar tarballs ("could not close file: Invalid argument" when creating pg_wal.tar of size ~ 2^31 bytes)
Date: 2025-01-09 09:28:05
Message-ID: CAKZiRmysRBFF4maSQeAknG2LqrX69k86w3AJ_QbPF9Q=++fTgw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jan 9, 2025 at 4:12 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
>
> On Tue, Jan 7, 2025 at 9:54 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > On Tue, Jan 7, 2025 at 5:23 AM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> > > Do you have a plan for moving ahead with this?
> >
> > I think that all looks good, and I'll go ahead and commit it in the
> > next day or two. Sorry for the delay.
>
> I changed some remaining off_t, because I don't want to worry about
> which ones can and can't overflow. Might as we'll get 'em all. I
> also noticed a warning due to the new lseek() macro, which just
> required adding it to plperl_system.h.
>
> And pushed.

Thank you very much, Thomas! (and best wishes in 2025)

-J.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2025-01-09 09:39:53 Re: Recovering from detoast-related catcache invalidations
Previous Message Richard Guo 2025-01-09 09:27:06 Re: Eager aggregation, take 3