Re: Windows pg_basebackup unable to create >2GB pg_wal.tar tarballs ("could not close file: Invalid argument" when creating pg_wal.tar of size ~ 2^31 bytes)

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Dilip Kumar <dilip(dot)kumar(at)enterprisedb(dot)com>
Subject: Re: Windows pg_basebackup unable to create >2GB pg_wal.tar tarballs ("could not close file: Invalid argument" when creating pg_wal.tar of size ~ 2^31 bytes)
Date: 2025-01-09 03:11:27
Message-ID: CA+hUKGKJieGQjeHVsJ2RGJJd6WXMVMgmNFLbj8ROo=8DJLXKhg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jan 7, 2025 at 9:54 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Tue, Jan 7, 2025 at 5:23 AM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> > Do you have a plan for moving ahead with this?
>
> I think that all looks good, and I'll go ahead and commit it in the
> next day or two. Sorry for the delay.

I changed some remaining off_t, because I don't want to worry about
which ones can and can't overflow. Might as we'll get 'em all. I
also noticed a warning due to the new lseek() macro, which just
required adding it to plperl_system.h.

And pushed.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message jian he 2025-01-09 03:15:09 Re: Eager aggregation, take 3
Previous Message Michael Paquier 2025-01-09 02:59:38 Re: Make pg_stat_io view count IOs as bytes instead of blocks