Re: RFC: split OBJS lines to one object per line

From: Mahendra Singh <mahi6run(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Peter Geoghegan <pg(at)bowt(dot)ie>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: RFC: split OBJS lines to one object per line
Date: 2019-12-18 03:00:24
Message-ID: CAKYtNAqJmFuH1fANV5d0ybn1g8iMxonxHfz9gVZy13YCgtiVnQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 18 Dec 2019 at 07:23, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Tue, Dec 17, 2019 at 11:40:17PM +0530, Mahendra Singh wrote:
> > I found some inconsistency in alphabetical order in
> > src/backend/tsearch/Makefile, src/backend/utils/Makefile and
> > src/pl/plpython/Makefile files. Attached patch is fixing those order
> > related inconsistency.
>
> Thanks, committed. The one-liner style is also used in ifaddrs, but

Thanks Michael for quick response.

> fmgrtab.c is generated so I have left that out. Now, have you tried
> to compile plpython before sending this patch? Because as you forgot
> to add one backslash after WIN32RES, compilation was failing there.
> And you also forgot to remove two backslashes at the end of the other
> two lists modified :)

Sorry, I forgot to add backslashes. I will take care from next time.

Thanks and Regards
Mahendra Thalor
EnterpriseDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2019-12-18 03:16:01 Re: segmentation fault when cassert enabled
Previous Message Amit Langote 2019-12-18 02:23:17 Re: empty column name in error message