| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Mahendra Singh <mahi6run(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Peter Geoghegan <pg(at)bowt(dot)ie>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: RFC: split OBJS lines to one object per line |
| Date: | 2019-12-18 01:53:37 |
| Message-ID: | 20191218015337.GC1836@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Dec 17, 2019 at 11:40:17PM +0530, Mahendra Singh wrote:
> I found some inconsistency in alphabetical order in
> src/backend/tsearch/Makefile, src/backend/utils/Makefile and
> src/pl/plpython/Makefile files. Attached patch is fixing those order
> related inconsistency.
Thanks, committed. The one-liner style is also used in ifaddrs, but
fmgrtab.c is generated so I have left that out. Now, have you tried
to compile plpython before sending this patch? Because as you forgot
to add one backslash after WIN32RES, compilation was failing there.
And you also forgot to remove two backslashes at the end of the other
two lists modified :)
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-12-18 02:11:45 | Re: [PATCH] Improve documentation of REINDEX options |
| Previous Message | Bruce Momjian | 2019-12-18 01:37:33 | Re: [PATCH] Tiny optimization. |