| From: | Mahendra Singh Thalor <mahi6run(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Guillaume Lelarge <guillaume(at)lelarge(dot)info>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Subject: | Re: Non-text mode for pg_dumpall |
| Date: | 2025-01-11 14:38:12 |
| Message-ID: | CAKYtNAo-6HZy-JhTYS321AxGE_BPCg7WTFVLeXTuFMZ6HYK2vg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks Alvaro for quick feedback.
On Sat, 11 Jan 2025 at 2:14 PM, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
wrote:
> Hmm, this patch adds a function connectDatabase() to pg_restore, but a
> function that's almost identical already exists in pg_dumpall.
Yes, you are right. Both functions are same as I copied this function from
pg_dumpall.c.
> suggest they should be unified. Maybe create a new file for connection
> management routines? (since this clearly doesn't fit common.c nor
> dumputils.c).
Sure. I will create a new file and I will move these common functions into
that.
Thanks and regards
Mahendra Singh Thalor
https://www.EnterpriseDB.com/
>
>
> --
> Álvaro Herrera 48°01'N 7°57'E —
> https://www.EnterpriseDB.com/
> "In Europe they call me Niklaus Wirth; in the US they call me Nickel's
> worth.
> That's because in Europe they call me by name, and in the US by value!"
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sami Imseih | 2025-01-11 15:01:16 | Re: why there is not VACUUM FULL CONCURRENTLY? |
| Previous Message | Guillaume Lelarge | 2025-01-11 14:02:15 | Re: explain analyze rows=%.0f |