Re: Non-text mode for pg_dumpall

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Mahendra Singh Thalor <mahi6run(at)gmail(dot)com>
Cc: Guillaume Lelarge <guillaume(at)lelarge(dot)info>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Subject: Re: Non-text mode for pg_dumpall
Date: 2025-01-11 08:44:39
Message-ID: 202501110844.5ztsym4vbflm@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hmm, this patch adds a function connectDatabase() to pg_restore, but a
function that's almost identical already exists in pg_dumpall. I
suggest they should be unified. Maybe create a new file for connection
management routines? (since this clearly doesn't fit common.c nor
dumputils.c).

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"In Europe they call me Niklaus Wirth; in the US they call me Nickel's worth.
That's because in Europe they call me by name, and in the US by value!"

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Junwang Zhao 2025-01-11 08:57:12 Re: Some ExecSeqScan optimizations
Previous Message Mahendra Singh Thalor 2025-01-11 07:45:49 Re: Non-text mode for pg_dumpall