From: | Dinesh Kumar <dinesh(dot)kumar(at)enterprisedb(dot)com> |
---|---|
To: | "J(dot)F(dot) Oster" <jinfroster(at)mail(dot)ru> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: PATCH: Choose best width for Data Output columns of Query tool |
Date: | 2013-12-09 08:58:42 |
Message-ID: | CAKWsr7jOJ-UyvKq7Z6svd8ZBc-z1hSk5_ZW-MH3Hifzxz1_pAA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi,
On Thu, Dec 5, 2013 at 8:42 PM, J.F. Oster <jinfroster(at)mail(dot)ru> wrote:
> Hello Dinesh,
>
> Thursday, December 5, 2013, 1:38:10 PM, you wrote:
>
>
> DK> I have reviewed your patch and managed to traverse each line
> DK> of your code, except "AutoColumn" function body. Could you give me
> DK> some information, when the pgAdmin goes to this function call.
>
> You mean AutoSizeColumn()? In fact it is used only in
> ctlSQLGrid::OnLabelDoubleClick(). If user doubleclicks column label
> holding Ctrl/Meta, the column's manual size is forgotten and this
> function is called to resize that single column immediately (otherwise
> the user wouldn't notice the effect until re-execution of query).
OK. Thank you.
@Dave:
It seems good to me. I might be wrong in some places in analyzing this
patch, hence requesting you to look into this once.
Thanks in advance.
Regards,
Dinesh
> DK> I have verified it in Mac/Linux/Windows, seems working fine. :)
>
> Good news, thank you!
>
> --
> Best regards,
> Vadim
>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Dinesh Kumar | 2013-12-10 10:49:11 | Re: pgAdmin 1.18.0 + slony-I 2.2.0 + PG 9.3 |
Previous Message | Dave Page | 2013-12-06 17:21:19 | Re: PATCH: Save & restore last active panel in Options dialogue |