Re: Password setting having somewhat bizarre results.

H
i Dave,

On Thu, Aug 29, 2013 at 7:29 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
>
> On Thu, Aug 29, 2013 at 1:01 PM, Dinesh Kumar <
> dinesh(dot)kumar(at)enterprisedb(dot)com> wrote:
>
>> Hi Dave,
>>
>> Sorry for the delay on this issue.
>>
>> Yes, i am able to reproduce the problem in Linux but not in windows. I am
>> attaching the fix for this issue. After applying this fix, the behaviour in
>> windows and linux are same.
>>
>> Kindly let me know if i miss anything here.
>>
>
> Still not quite right I'm afraid. If I open a user account with no
> pre-existing expiry, then the dialogue will try to execute:
>
> ALTER ROLE rolename
> VALID UNTIL 'infinity';
>
> As I haven't changed anything on the dialogue, it shouldn't try to make
> any changes (or, enable the OK button). Also, the dialogue itself shows the
> current date - it should be blank. If I choose a date - then it still tries
> to set the expiry to infinity!
>
> Tested on Mac.
>

Thanks for your inputs. In the current implementation, if the "calender
control" doesn't have a proper value, then we do add "infinity" to the sql
statement. It's the same case, in the edit/creating a role.

I am not sure, whether we need to follow this implementation or not. I
mean, adding "infinity" to the end of sql statement if the calender control
value is an empty.

But, i have removed this "infinity" condition and attaching the patch.

Kindly let me your inputs on this.

Thanks in advance.

>
>

> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Dinesh

--
*Dinesh Kumar*
Software Engineer

Ph: +918087463317
Skype ID: dinesh.kumar432
www.enterprisedb.co
<http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
*
Follow us on Twitter*
@EnterpriseDB

Visit EnterpriseDB for tutorials, webinars,
whitepapers<http://www.enterprisedb.com/resources-community> and
more <http://www.enterprisedb.com/resources-community>

On Thu, Aug 29, 2013 at 7:29 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
>
> On Thu, Aug 29, 2013 at 1:01 PM, Dinesh Kumar <
> dinesh(dot)kumar(at)enterprisedb(dot)com> wrote:
>
>> Hi Dave,
>>
>> Sorry for the delay on this issue.
>>
>> Yes, i am able to reproduce the problem in Linux but not in windows. I am
>> attaching the fix for this issue. After applying this fix, the behaviour in
>> windows and linux are same.
>>
>> Kindly let me know if i miss anything here.
>>
>
> Still not quite right I'm afraid. If I open a user account with no
> pre-existing expiry, then the dialogue will try to execute:
>
> ALTER ROLE rolename
> VALID UNTIL 'infinity';
>
> As I haven't changed anything on the dialogue, it shouldn't try to make
> any changes (or, enable the OK button). Also, the dialogue itself shows the
> current date - it should be blank. If I choose a date - then it still tries
> to set the expiry to infinity!
>
> Tested on Mac.
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>