Unnecessary #include in objectaddress.h?

From: Adam Brightwell <adam(dot)brightwell(at)crunchydatasolutions(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Unnecessary #include in objectaddress.h?
Date: 2015-07-20 21:10:48
Message-ID: CAKRt6CT6Av0SdRWK76yA8_YPfkWZC=UhNXOZnOccvR1bYweDjA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

All,

While looking at the include dependency graph for objectaddress.h:

http://doxygen.postgresql.org/objectaddress_8h.html

I saw that pg_list.h is both included and inherited (through multiple
paths) by objectaddress.h. Perhaps this doesn't matter, but I thought
I would at least bring it up and propose removing this redundant
#include from objectaddress.h.

If it makes sense to do so, I have attached a patch that removes it.

Thanks,
Adam

--
Adam Brightwell - adam(dot)brightwell(at)crunchydatasolutions(dot)com
Database Engineer - www.crunchydatasolutions.com

Attachment Content-Type Size
objectaddress-include-cleanup.patch text/x-patch 428 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-07-20 21:17:34 Re: "make check" changes have caused buildfarm deterioration.
Previous Message Andrew Dunstan 2015-07-20 20:51:13 "make check" changes have caused buildfarm deterioration.