pg_upgrade: prep_status doesn't translate messages

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: pg_upgrade: prep_status doesn't translate messages
Date: 2019-06-10 04:57:14
Message-ID: CAKPRHzL7O6Jg4bai+c9BrA1e=fqHSmh6PKr1OPTiD_dx9HbpUg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello.

In pg_upgrade, prep statuts is shown in English even if LANG is
set to other languages.

$ LANG=ja_JP.UTF8 pg_upgrade ...
<"Performing Consistency Checks on Old Live Server" in Japanese>
--------------------------------------------------
Checking cluster versions ok
Checking database user is the install user ok
Checking database connection settings ok
Checking for prepared transactions ok
...
<"*Clusters are compatible*" in Japanese>

prep_status is marked as GETTEXT_TRIGGERS but actually doesn't
translate. I suppose the reason is we don't have a general and
portable means to align the message strings containing non-ascii
characters.

I'd like to propose to append " ... " instead of aligning messages.

Checking cluster versions ... ok
Checking database user is the install user ... ok
Checking database connection settings ... ok
Checking for prepared transactions ... ok

If we don't do that, translation lines in po files are
useless. prep_stauts must be removed from TETTEXT_TRIGGERS, and a
comment that explains the reason for not translating.

Any opinions?

regardes.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
0001-Change-format-of-prep-status-of-pg_upgrade.patch application/octet-stream 1.3 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2019-06-10 04:58:38 Fix testing on msys when builddir is under /c mount point
Previous Message Tom Lane 2019-06-10 02:12:46 Re: [PATCH] Fix potential memoryleak in guc.c