Fix testing on msys when builddir is under /c mount point

From: Noah Misch <noah(at)leadboat(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Fix testing on msys when builddir is under /c mount point
Date: 2019-06-10 04:58:38
Message-ID: 20190610045838.GA238501@rfd.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Several TAP test suites have a need to translate from an msys path to a
Windows path. They currently use two ways to do that:

1. TestLib::real_dir, new in v11, is sound but works for directories only.
2. The $vfs_path approach is semi-private to PostgresNode.pm and 017_shm.pl,
and it does not work if the file falls in a mount point other than "/".
For example, it has been doing the wrong thing when builddir is
/c/nm/postgresql (falling in mount point /c).

I'd like to fix the mount point problem and consolidate these two methods. I
plan to call it TestLib::perl2host, since it translates a path in Perl's
notion of the filesystem to a path in the @host@ notion of the filesystem.
Attached.

Attachment Content-Type Size
msys2-mount-point-v1.patch text/plain 4.5 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Khandekar 2019-06-10 05:07:44 Re: Minimal logical decoding on standbys
Previous Message Kyotaro Horiguchi 2019-06-10 04:57:14 pg_upgrade: prep_status doesn't translate messages