Re: Patch: make behavior of all versions of the "isinf" function be similar

From: Vitaly Burovoy <vitaly(dot)burovoy(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch: make behavior of all versions of the "isinf" function be similar
Date: 2016-02-01 12:07:51
Message-ID: CAKOSWN=Gf4prZO54FxcjYTuXPXO6t32NOXo-E-NU9KCf2u236g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 1/31/16, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> 2. POSIX:2008 only requires that "The isinf() macro shall return a
> non-zero value if and only if its argument has an infinite value."
> Therefore, any assumption about the sign of the result is wrong anyway,
> and any patch that depends on it will be rejected, regardless of what
> isinf.c does. Or else, if you can convince us that such an assumption
> is really valuable, we'd need isinf.c more not less so that we can
> replace isinf() on platforms where it doesn't meet the stronger spec.
>
> regards, tom lane

Ok, then I'll use "is_infinite" from "float.c".
But why functions' (in "src/port/isinf.c") behavior are different? It
is a bit confusing…
--
Best regards,
Vitaly Burovoy

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2016-02-01 12:15:20 Re: Several problems in tab-completions for SET/RESET
Previous Message Andres Freund 2016-02-01 12:04:05 Re: Template for commit messages