Re: Patch: make behavior of all versions of the "isinf" function be similar

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Vitaly Burovoy <vitaly(dot)burovoy(at)gmail(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch: make behavior of all versions of the "isinf" function be similar
Date: 2016-02-02 20:02:34
Message-ID: 11459.1454443354@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Vitaly Burovoy <vitaly(dot)burovoy(at)gmail(dot)com> writes:
> On 1/31/16, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> 2. POSIX:2008 only requires that "The isinf() macro shall return a
>> non-zero value if and only if its argument has an infinite value."

> Ok, then I'll use "is_infinite" from "float.c".

Yeah, that's good.

> But why functions' (in "src/port/isinf.c") behavior are different? It
> is a bit confusing

Probably the authors of those different implementations were making it
match the behavior of whatever isinf() they had locally. I don't feel
a need to change isinf.c --- it should be zero-maintenance at this
point, especially if we suspect it is no longer used anywhere.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2016-02-02 20:09:44 Re: PostgreSQL Auditing
Previous Message Jim Nasby 2016-02-02 20:02:19 Re: PostgreSQL Auditing