Re: PATCH: To fix the issue in Database node (pgAdmin4)

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: To fix the issue in Database node (pgAdmin4)
Date: 2017-01-13 10:00:32
Message-ID: CAKKotZTfKgD8fq9a2uxTaez7CPHZ=J44Nc6ig3M9v6uAxVUOOw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

I am not able to re-produce it, I reviewed reconnect to database logic and
it is not affected by this patch, Would you please provide me exact steps?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Jan 9, 2017 at 8:27 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Friday, December 30, 2016, Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA patch to fix the issue in database node where it was not showing
>> comments if database created with allow_connections=false.
>> RM#2024
>>
>
> Whilst it otherwise seems fine, if I try to change the comment on a
> database that *does* allow connections through the properties dialogue, I
> immediately get asked if I want to reconnect.
>
> Thanks, Dave.
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Neel Patel 2017-01-13 10:55:43 [pgAdmin4][patch]: RM 1967 - Layout is not remembered
Previous Message Murtuza Zabuawala 2017-01-13 09:31:59 PATCH: To display column information properly in Properties Panel (pgAdmin4)