From: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
---|---|
To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | [pgAdmin4][PATCH] To handle "char" type in column node |
Date: | 2017-02-06 10:20:30 |
Message-ID: | CAKKotZTcvhME5hhb99HGLTrYJvWEwP-F8ZbA9kKOTjNNC2t_dA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi,
PFA minor patch to handle "char" type while creating columns in Column node.
*Issue:* simplejson parse '*"char"*' as valid json, hence when we perform
simplejson.loads(request.args) operation '"char"' gets converted to 'char'
I had to handle it manually as of now, I did not find any other workaround
to handle this issue, I went over several SO question most of them
suggested manual handling.
This behavior is only in Column node, table & type nodes are not affectted
by .loads() method as we send data as column collection.
RM#2152
*Snippet of issue:*
import simplejson as json
print(json.loads('"char"'))
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment | Content-Type | Size |
---|---|---|
fix_char_type_handling.diff | text/plain | 1.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2017-02-06 10:32:18 | Re: Acceptance Tests against a browser (WIP) |
Previous Message | Dave Page | 2017-02-06 10:01:43 | Re: [pgAdmin4][PATCH] To fix graphical explain for Insert/Update/Delete quries |