From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][PATCH] To handle "char" type in column node |
Date: | 2017-02-06 10:59:13 |
Message-ID: | CA+OCxoyLx6x439UpEurn0+fFy_zuF1AMspG7u=14dkw7YBOqwA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks - applied.
On Mon, Feb 6, 2017 at 10:20 AM, Murtuza Zabuawala
<murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA minor patch to handle "char" type while creating columns in Column node.
>
> Issue: simplejson parse '"char"' as valid json, hence when we perform
> simplejson.loads(request.args) operation '"char"' gets converted to 'char'
> I had to handle it manually as of now, I did not find any other workaround
> to handle this issue, I went over several SO question most of them suggested
> manual handling.
> This behavior is only in Column node, table & type nodes are not affectted
> by .loads() method as we send data as column collection.
> RM#2152
>
> Snippet of issue:
> import simplejson as json
> print(json.loads('"char"'))
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2017-02-06 12:53:19 | pgAdmin 4 commit: Compatibility fixes for newer versions of Jinja2 (e.g |
Previous Message | Dave Page | 2017-02-06 10:59:06 | pgAdmin 4 commit: Fix handling of "char" columns. Fixes #2152 |