Re: [pgAdmin4] [RM#3824] Make bootstrap tabs visible on dashboard

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4] [RM#3824] Make bootstrap tabs visible on dashboard
Date: 2018-12-18 14:34:17
Message-ID: CAKKotZT7im6ckO1VXu+4reBud5BmTqSGRJ2zSPtYDPXmffHHQw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

Please ignore my previous patch.

Here is an updated patch which includes tab hover CSS changes as well.

On Tue, Dec 18, 2018 at 7:46 PM Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi Dave,
>
> Here is updated patch, Please review.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
>
> On Tue, Dec 18, 2018 at 3:30 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> On Mon, Dec 17, 2018 at 11:38 AM Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> PFA patch which will make the bootstrap tabs visible when active and
>>> also when the user hovers on them.
>>>
>>
>> It does what it says, but the styling doesn't match the rest of the tabs
>> in the application. Can you make them look like the wcDocker tabs please
>> (except, with the colours reversed as they are - white background for the
>> bar and inactive tabs instead of grey, white for the active tab instead of
>> gray).
>>
>> Thanks!
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>

Attachment Content-Type Size
RM_3824_v2.diff application/octet-stream 6.1 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Khushboo Vashi 2018-12-19 09:29:54 [pgAdmin4][Patch]: RM 3796 - Grant Wizard: Text should be "Please add privileges..." instead of "Please select privileges..
Previous Message Murtuza Zabuawala 2018-12-18 14:16:23 Re: [pgAdmin4] [RM#3824] Make bootstrap tabs visible on dashboard