Re: [pgAdmin4] [RM#3824] Make bootstrap tabs visible on dashboard

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4] [RM#3824] Make bootstrap tabs visible on dashboard
Date: 2018-12-20 09:53:58
Message-ID: CA+OCxoxyL=h-Ao7ugBTw=txdSVpwF+YSD6Vj4kHq4pd7Ewz6MA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, applied.

On Tue, Dec 18, 2018 at 2:34 PM Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi Dave,
>
> Please ignore my previous patch.
>
> Here is an updated patch which includes tab hover CSS changes as well.
>
>
> On Tue, Dec 18, 2018 at 7:46 PM Murtuza Zabuawala <
> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>
>> Hi Dave,
>>
>> Here is updated patch, Please review.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>>
>> On Tue, Dec 18, 2018 at 3:30 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Hi
>>>
>>> On Mon, Dec 17, 2018 at 11:38 AM Murtuza Zabuawala <
>>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi,
>>>>
>>>> PFA patch which will make the bootstrap tabs visible when active and
>>>> also when the user hovers on them.
>>>>
>>>
>>> It does what it says, but the styling doesn't match the rest of the tabs
>>> in the application. Can you make them look like the wcDocker tabs please
>>> (except, with the colours reversed as they are - white background for the
>>> bar and inactive tabs instead of grey, white for the active tab instead of
>>> gray).
>>>
>>> Thanks!
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2018-12-20 10:08:55 Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export
Previous Message Dave Page 2018-12-20 09:53:40 pgAdmin 4 commit: Ensure the dashboard tabs are styles correctly. Fixes