Re: [pgAdmin4][PATCH] To fix the of issue in table node

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][PATCH] To fix the of issue in table node
Date: 2017-05-09 14:36:34
Message-ID: CAKKotZT0tumuUMJYg5czrH4NBkaxKHdvnGkXyeh+F+BG3pejOQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

Please find updated patch.

Updated logic to convert name only if name is of type int/long/float
(Python2) or of type int/float (Python3) instead of blindly convert it to
string.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, May 9, 2017 at 7:06 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi,
>
> PFA minor patch to fix the issue in table node where it fails to create
> table when user provides numeric table name eg: 123.
> RM#2284
>
> Issue is when use json.loads() it converts string "123" into integer 123.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Attachment Content-Type Size
RM_2284_v1.diff text/plain 3.0 KB

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Sarah McAlear 2017-05-09 15:33:22 Re: [patch] Dependents and Dependencies in GreenPlum
Previous Message Murtuza Zabuawala 2017-05-09 13:36:23 [pgAdmin4][PATCH] To fix the of issue in table node