| From: | Sarah McAlear <smcalear(at)pivotal(dot)io> |
|---|---|
| To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
| Cc: | Dave Page <dpage(at)pgadmin(dot)org>, Robert Eckhardt <reckhardt(at)pivotal(dot)io>, Joao Pedro De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Matthew Kleiman <mkleiman(at)pivotal(dot)io> |
| Subject: | Re: [patch] Dependents and Dependencies in GreenPlum |
| Date: | 2017-05-09 15:33:22 |
| Message-ID: | CAGRPzo_ATD7Erwz=5Eay1GDfXnDq4DvEinYvfsSGQbVBmcxrNg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Akshay!
> Some test file names ended with "*_sql_template.py*" do we need to add
> that string ?
we added this suffix after moving the tests up a level to tables/tests to
clarify what subject they applied to. we changed the suffix to "_sql.py"
- Files "test_column_acl_sql_template.py" and "test_column_properties_sql_
> template.py" should be moved from tables->tests to tables->column->tests.
> As it's related to column.
> - Files "test_trigger_get_oid_sql_template.py" and "test_trigger_nodes_sql
> _template.py" should be moved from tables->tests to
> tables->triggers->tests. As its related to triggers.
these tests are related to the sql files in tables/templates/column, not
tables/column, so moving them into tables/column would be more confusing.
Following test cases are failing
Thank you, fixed, see new patch. Can you confirm that TestTablesNodeSql
doesn't fail in your environment?
Thanks,
George & Sarah
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-error-while-checking-Dependents-and-Dependencies.patch | application/octet-stream | 70.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Harshal Dhumal | 2017-05-09 16:32:10 | Re: Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4] |
| Previous Message | Murtuza Zabuawala | 2017-05-09 14:36:34 | Re: [pgAdmin4][PATCH] To fix the of issue in table node |