From: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
---|---|
To: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
Cc: | Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch]: Allow user to choose background colour for server |
Date: | 2017-11-15 08:58:01 |
Message-ID: | CAKKotZSYbWzmSc_CKjUzM7YVGQK63Hvu=oFXH0_yq1eDvoOv8g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Wed, Nov 15, 2017 at 1:20 PM, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com
> wrote:
> Hi Murtuza,
>
> On Wed, Nov 15, 2017 at 12:58 PM, Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA new patch.
>>
> If I have reviewed correctly, the current patch allows to select the
> colour for background color for server, and its children.
> I believe - we should allow to select text color too for better
> readability.
>
> Yes Ashesh, After our discussion I tried that but with all the different
colours in browser tree it looks cartoonish.
So for consistancy I kept it as it is.
Dave - thoughts?
>
> --
> Thanks & Regards,
> Ashesh Vashi
>
>
> On Wed, Nov 15, 2017 at 10:33 AM, Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> Please hold on this patch, As discussed with Ashesh I need to make some
>>> changes, I'll send new patch.
>>>
>>> On Wed, Nov 15, 2017 at 10:07 AM, Murtuza Zabuawala <
>>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi,
>>>>
>>>> PFA patch which will allow user to choose background colour for the
>>>> server.
>>>> RM#1383
>>>>
>>>> --
>>>> Regards,
>>>> Murtuza Zabuawala
>>>> EnterpriseDB: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>>
>>>
>>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Ashesh Vashi | 2017-11-15 09:26:21 | Re: [pgAdmin4][Patch]: Allow user to choose background colour for server |
Previous Message | Ashesh Vashi | 2017-11-15 07:50:30 | Re: [pgAdmin4][Patch]: Allow user to choose background colour for server |