Re: [pgAdmin4][Patch]: Allow user to choose background colour for server

On Wed, Nov 15, 2017 at 2:28 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> On Wed, Nov 15, 2017 at 1:20 PM, Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi Murtuza,
>>
>> On Wed, Nov 15, 2017 at 12:58 PM, Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> PFA new patch.
>>>
>> If I have reviewed correctly, the current patch allows to select the
>> colour for background color for server, and its children.
>> I believe - we should allow to select text color too for better
>> readability.
>>
>> ​Yes Ashesh, After our discussion I tried that but with all the different
> colours in browser tree it looks cartoonish.
>
I am not sure - what looked like cartoonish to you (totally depend on the
color choices made by the users). :-)

If I choose any dark color as background color, text in nodes won't be
clear to the user, and that will make the tree nodes completely unusable.
If we allow to choose the foreground/text color, those dark colors will
become usable by choosing suitable light color as text colors.

I don't want to make any decision here, just asking for opinions from
others.

So - Again ball is back in Dave's courtyard :-).

--
Thanks & Regards,
Ashesh Vashi

So for consistancy I kept it as it is.​
>

> Dave - thoughts?
>>
>> --
>> Thanks & Regards,
>> Ashesh Vashi
>>
>>
>> On Wed, Nov 15, 2017 at 10:33 AM, Murtuza Zabuawala <
>>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi,
>>>>
>>>> Please hold on this patch, As discussed with Ashesh I need to make some
>>>> changes, I'll send new patch.
>>>>
>>>> On Wed, Nov 15, 2017 at 10:07 AM, Murtuza Zabuawala <
>>>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> PFA patch which will allow user to choose background colour for the
>>>>> server.
>>>>> RM#1383
>>>>>
>>>>> --
>>>>> Regards,
>>>>> Murtuza Zabuawala
>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>>
>>>>
>>>
>>
>