Re: [RM#4468] Add RE-SQL tests for Type node

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [RM#4468] Add RE-SQL tests for Type node
Date: 2019-07-15 12:15:48
Message-ID: CAKKotZSPVaqfy_iQKdYnbuN=MCyRVeLKAtxZZXS_utNawvXubA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

PFA patch to fix the ACL order so that it RE-SQL tests for type node works
consistently on all the platforms.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Jul 15, 2019 at 2:55 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Thanks, patch applied.
>
> On Mon, Jul 15, 2019 at 7:57 AM Murtuza Zabuawala <
> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please find patch for RE-SQL type node.
>>
>> - Fixed a bug in update.sql which is found during writing tests
>> - Added logging for JSON file when it fails to load
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Attachment Content-Type Size
fix_acl_order.diff application/octet-stream 3.3 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2019-07-15 12:32:03 [pgAdmin4][Patch]: RM 4428 and 4448
Previous Message Aditya Toshniwal 2019-07-15 11:06:15 [pgAdmin][RM4469] Add RE-SQL test cases for Sequences