Re: [RM#4468] Add RE-SQL tests for Type node

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [RM#4468] Add RE-SQL tests for Type node
Date: 2019-07-15 13:48:37
Message-ID: CA+OCxoxEa7HsDdiCbhF=+apjyC+xfBngh3Sch2f_7Huwv8OWuQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, applied.

On Mon, Jul 15, 2019 at 1:16 PM Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi Dave,
>
> PFA patch to fix the ACL order so that it RE-SQL tests for type node works
> consistently on all the platforms.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
>
> On Mon, Jul 15, 2019 at 2:55 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Thanks, patch applied.
>>
>> On Mon, Jul 15, 2019 at 7:57 AM Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> Please find patch for RE-SQL type node.
>>>
>>> - Fixed a bug in update.sql which is found during writing tests
>>> - Added logging for JSON file when it fails to load
>>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2019-07-15 13:55:10 pgAdmin 4 commit: Fix sequence reverse engineered SQL generation with q
Previous Message Dave Page 2019-07-15 13:48:25 pgAdmin 4 commit: Stabilise ordering of ACLs in Type RE-SQL tests to pr