| From: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch]: To fix the issue in Debugger module |
| Date: | 2017-12-04 09:13:07 |
| Message-ID: | CAKKotZSFF3v5Ln+ATMX33H0_nR7H903sY97pyksk+kk4eSWLug@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Dave,
PFA updated patch.
On Sat, Dec 2, 2017 at 10:42 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Hi
>
> On Thursday, November 30, 2017, Murtuza Zabuawala <
> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> PFA patch to fix the issue where debugger failed to run when user tries
>> to debug the function which call itself recursively.
>> RM#2524
>>
>
> This seems to fix the recursion problem, but walking the stack doesn't
> work - no matter which frame I click on, the highlighted source code line
> remains that of the top frame, as does the value of in_val on the
> Parameters tab.
>
Fixed.
It's due to improper conditional logic to select frame id in JS code.
>
> Thanks.
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
| Attachment | Content-Type | Size |
|---|---|---|
| RM_2524_v1.diff | text/plain | 9.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Murtuza Zabuawala | 2017-12-04 14:56:44 | [pgAdmin4][Patch]: To fix the issue in File manager |
| Previous Message | Khushboo Vashi | 2017-12-04 07:01:01 | Re: [pgAdmin4][Patch]: RM #2849 - Allow editing of data on tables with OIDs but no primary key |