Re: [pgAdmin4][Patch]: To fix the issue in Debugger module

Thanks, patch applied!

On Mon, Dec 4, 2017 at 6:13 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi Dave,
>
> PFA updated patch.
>
> On Sat, Dec 2, 2017 at 10:42 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> On Thursday, November 30, 2017, Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> PFA patch to fix the issue where debugger failed to run when user tries
>>> to debug the function which call itself recursively.
>>> RM#2524
>>>
>>
>> This seems to fix the recursion problem, but walking the stack doesn't
>> work - no matter which frame I click on, the highlighted source code line
>> remains that of the top frame, as does the value of in_val on the
>> Parameters tab.
>>
> ​Fixed.​
>
> ​It's due to improper conditional logic to select frame id in JS code.​
>
>
>>
>> Thanks.
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company