From: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: PACTH: To fix the issue while selecting primary key in table (pgAdmin4) |
Date: | 2016-06-24 10:20:27 |
Message-ID: | CAKKotZS1WoVXPbPjN0=8QN0iwdnb5CmsirAEstC_K0eJLGZG7A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Dave,
I have fixed the issue with Switch control, now it's working as expected
along with DepsCell functionality.
PFA patch RM#1235 with Switch Cell.
While debugging the issue I have found typo in "index.js" which is also
fixed with patch.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Thu, Jun 23, 2016 at 5:07 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Hi
>
> On Wed, Jun 22, 2016 at 12:56 PM, Murtuza Zabuawala
> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> > Hi,
> >
> > PFA minor patches to fix two issues mentioned in RM#1235 & RM#1234.
>
> I've pushed the fix for 1234, however the fix for 1235 changes the
> control used in the grid to a checkbox which is inconsistent with the
> rest of the app where we use switches. Can that be changed?
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
Attachment | Content-Type | Size |
---|---|---|
RM_1235.patch | application/octet-stream | 2.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2016-06-24 10:47:21 | Re: pgAdmin IV API test cases patch |
Previous Message | Dave Page | 2016-06-24 09:34:40 | Re: [pgAdmin4][Patch]: RM#1242 - Cleanup busy indication for tree view and tab panes |