Re: PACTH: To fix the issue while selecting primary key in table (pgAdmin4)

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PACTH: To fix the issue while selecting primary key in table (pgAdmin4)
Date: 2016-06-24 13:06:13
Message-ID: CA+OCxozzsKyY_RbnL8ENTy+-uT9D+eBWjoK1GTH49A75AG0oSw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, applied.

On Fri, Jun 24, 2016 at 11:20 AM, Murtuza Zabuawala
<murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> I have fixed the issue with Switch control, now it's working as expected
> along with DepsCell functionality.
>
> PFA patch RM#1235 with Switch Cell.
>
> While debugging the issue I have found typo in "index.js" which is also
> fixed with patch.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Thu, Jun 23, 2016 at 5:07 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> Hi
>>
>> On Wed, Jun 22, 2016 at 12:56 PM, Murtuza Zabuawala
>> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>> > Hi,
>> >
>> > PFA minor patches to fix two issues mentioned in RM#1235 & RM#1234.
>>
>> I've pushed the fix for 1234, however the fix for 1235 changes the
>> control used in the grid to a checkbox which is inconsistent with the
>> rest of the app where we use switches. Can that be changed?
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-06-24 13:09:36 pgAdmin 4 commit: Handle special chars and spaces properly in select2 c
Previous Message Dave Page 2016-06-24 13:06:02 pgAdmin 4 commit: Allow toggling of the Primary Key option in the un-ex