Re: [pgAdmin4][RM#3105] Allow user to insert new row if PK is in capital letters

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][RM#3105] Allow user to insert new row if PK is in capital letters
Date: 2018-02-16 10:27:36
Message-ID: CAKKotZS=MGh8dNOXNnrW7aVOeywqfG_gnma1E=aByM5SeAriKQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

PFA updated patch, which includes feature test to test the scenario going
forward.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Thu, Feb 15, 2018 at 7:53 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> ​Sure, will do that.​
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Thu, Feb 15, 2018 at 7:34 PM, Joao De Almeida Pereira <
> jdealmeidapereira(at)pivotal(dot)io> wrote:
>
>> Hello Murtuza,
>> Just reviewed your patch, and it looks good.
>> Do you think you can wrap some tests around this behavior to ensure it
>> doesn't happen again in the future?
>>
>> Thanks
>> Joao
>>
>> On Thu, Feb 15, 2018 at 8:34 AM Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> PFA patch to fix the issue user was not able to insert new row in the
>>> table via 'view data' if the PK is in capital letters.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>

Attachment Content-Type Size
RM_3105_v1.diff text/plain 7.2 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Joao De Almeida Pereira 2018-02-16 14:30:30 Re: [pgAdmin4][RM#3105] Allow user to insert new row if PK is in capital letters
Previous Message Joao De Almeida Pereira 2018-02-15 16:23:47 Re: [pgAdmin4][RM#2950] Add marker to dashboard queries