Re: [pgAdmin4][Patch]: RM #3180 Index node is missing from the tree view of the table node

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM #3180 Index node is missing from the tree view of the table node
Date: 2018-03-29 13:06:40
Message-ID: CAKKotZRynLe885bAzH94kgv0M=4Tg3c13YfLRmxtMT72HqmKHA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Akshay,

I have concerns regarding the fix, As you negate the condition, Before the
fix it was not displaying Index node for Tables but after the fix it will
not display it for Partition tables.
But when I read the Postgres docs it say,
*Partitions may themselves be defined as partitioned tables, using what is
called sub-partitioning. Partitions may have their own indexes, constraints
and default values, distinct from those of other partitions. Indexes must
be created separately for each partition. See CREATE TABLE
<https://www.postgresql.org/docs/10/static/sql-createtable.html> for more
details on creating partitioned tables and partitions.*
Ref: https://www.postgresql.org/docs/10/static/ddl-partitioning.html (Sec:
5.10.2)

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Thu, Mar 29, 2018 at 6:05 PM, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com
> wrote:

> Hi Hackers,
>
> Please find the attached patch to fix RM #3180 Index node is missing from
> the tree view of the table node. This is a regression of one of the older
> commit.
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2018-03-29 13:09:35 pgAdmin 4 commit: Fix index node display on PG 10. Fixes #3180
Previous Message Dave Page 2018-03-29 13:03:24 Re: Bug #3083 fix