Re: PATCH: TO fix issue in Role node (pgAdmin4)

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: TO fix issue in Role node (pgAdmin4)
Date: 2016-06-09 07:36:12
Message-ID: CAKKotZRePAASe2NHsebhzpKFXrbtGLV=an3QbCiZi8xGGkw7EQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

Apologies, It was partial patch, missed JS side changes in last patch.

Please review updated patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jun 8, 2016 at 5:35 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> On Fri, Jun 3, 2016 at 3:19 PM, Murtuza Zabuawala
> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> > Hi,
> >
> > PFA patch to fix an issue while creating role if user has set expire
> date.
> > Current implements works only if datestyle is set to ISO,MDY in database
> for
> > others it fails.
> > (RM#1134)
>
> With this patch applied, the SQL shown on the SQL tab is blank when
> creating a role. If I revert it, I get the SQL I expect.
>
> Also - please see attached (which is unrelated to the patch, bar
> affecting the same field). The calendar at the top is always
> displayed, but I cannot choose a date from it. The one below works,
> but the selected date is immediately overwritten (presumably by the
> other calendar)!
>
> > Additionally I've fixed unwanted space indentation issue in Database
> node.
>
> Thanks, applied.
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Attachment Content-Type Size
RM_1134_v2.patch application/octet-stream 2.3 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Harshal Dhumal 2016-06-09 07:41:08 Email validation in setup.py [pgadmin4]
Previous Message Harshal Dhumal 2016-06-09 07:22:40 Removed unwanted empty_value form Select2 template [pgadmin4]