Re: PATCH: TO fix issue in Role node (pgAdmin4)

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: TO fix issue in Role node (pgAdmin4)
Date: 2016-06-08 12:05:54
Message-ID: CA+OCxoy=8urnq0KNhzrBecOcPeotgyrQgD1P8873X-yM6MMFvw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Fri, Jun 3, 2016 at 3:19 PM, Murtuza Zabuawala
<murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA patch to fix an issue while creating role if user has set expire date.
> Current implements works only if datestyle is set to ISO,MDY in database for
> others it fails.
> (RM#1134)

With this patch applied, the SQL shown on the SQL tab is blank when
creating a role. If I revert it, I get the SQL I expect.

Also - please see attached (which is unrelated to the patch, bar
affecting the same field). The calendar at the top is always
displayed, but I cannot choose a date from it. The one below works,
but the selected date is immediately overwritten (presumably by the
other calendar)!

> Additionally I've fixed unwanted space indentation issue in Database node.

Thanks, applied.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
Screen Shot 2016-06-08 at 12.59.46.png image/png 84.6 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Colin Beckingham 2016-06-08 12:15:42 pgadmin4: Server does not launch
Previous Message Dave Page 2016-06-08 11:57:00 pgAdmin 4 commit: Fix unwanted space indentation issue in Database node