From: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
---|---|
To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][RM#5213] Fixed materialized view issue when user perform refresh on it |
Date: | 2020-04-27 10:26:00 |
Message-ID: | CAKKotZRToBh2bhUM8=8agWuDA9GUH_E5tWaw76oQ24y5heV9rw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Akshay,
Here is an updated patch fixing test cases.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Mon, Apr 27, 2020 at 12:27 PM Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Thanks Akshay, flag not to run tests set to true when the check
> utility fails in-case if the binary path is not set, I will fix that issue
> as I did not consider more than one server scenario.
>
>
>
> On Mon, Apr 27, 2020 at 12:05 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Murtuza
>>
>> API test cases are not running, there is no error but all the tests are
>> skipped. I have run it for EPAS/PG 9.5 to 12 where the binary path for EPAS
>> is not set.
>>
>> I also found one issue where the proper error message is not shown if the
>> binary path is not set in the Preferences dialog. I have fixed those issues
>> and attached is the patch.
>> Please continue working on the attached patch.
>>
>> On Fri, Apr 24, 2020 at 6:27 PM Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> PFA patch to fix the issue for materialized view when the user performs
>>> refresh on it, large size materialized view can take longer time to refresh
>>> the view hence we will run it same as we run maintenance commands and it
>>> will also allow the user to view the status of the refresh command.
>>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
Attachment | Content-Type | Size |
---|---|---|
RM_5213_v3.diff | application/octet-stream | 19.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Satish V | 2020-04-27 12:00:08 | Re: [pgAdmin][RM5043] Column names not in creation order during - refresh via context menu required to resort them properly |
Previous Message | Khushboo Vashi | 2020-04-27 10:02:49 | Re: Patch to remove Python 2.7 support in the macOS Appbundle |