Re: Patch to remove Python 2.7 support in the macOS Appbundle

From: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Patch to remove Python 2.7 support in the macOS Appbundle
Date: 2020-04-27 10:02:49
Message-ID: CAFOhELfbAGUAAaRrLgx5ejSPSNDASfVBv-MyDwMWEuKZk3c_DA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Mon, Apr 27, 2020 at 3:28 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:

>
>
> On Mon, Apr 27, 2020 at 10:57 AM Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>>
>>
>> On Mon, Apr 27, 2020 at 3:23 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>>
>>>
>>> On Mon, Apr 27, 2020 at 10:52 AM Khushboo Vashi <
>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Dave,
>>>>
>>>> As we support PostgreSQL >=9.5, do we need to maintain SQL templates
>>>> for older versions?
>>>>
>>>
>>> Yes, for now. We're not actively removing support for old PostgreSQL
>>> versions, just not testing them.
>>>
>>>
>> Yes, we are not removing it but do we need to update SQL templates for
>> older versions when we do update for the supported versions in case of any
>> bug fixes?
>>
>
> If a bug is reported and is easily fixable, I don't see why not.
>
>
Sure but not every time it's easily fixable.:)

Team,
I am reviewing this patch.

Thanks,
Khushboo

>>>> Thanks,
>>>> Khushboo
>>>>
>>>> On Mon, Apr 27, 2020 at 3:16 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>
>>>>> The attached patch removes support for Python 2.7 in general from the
>>>>> macOS appbundle build, thus also removing special handling for use of the
>>>>> system Python installation.
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> Blog: http://pgsnake.blogspot.com
>>>>> Twitter: @pgsnake
>>>>>
>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2020-04-27 10:26:00 Re: [pgAdmin4][RM#5213] Fixed materialized view issue when user perform refresh on it
Previous Message Dave Page 2020-04-27 09:58:07 Re: Patch to remove Python 2.7 support in the macOS Appbundle