From: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool |
Date: | 2017-09-18 14:08:19 |
Message-ID: | CAKKotZRQduCPnCKzh43-fNUEcHL5KD+M51f_N1t0cOi3XFgRcg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Dave,
Sorry my bad, I didn't check the backend code, I assumed that it is coming
from psycopg2 and so I was focusing it to remove from client side :(
PFA updated patch.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Mon, Sep 18, 2017 at 7:19 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Hi
>
> On Mon, Sep 18, 2017 at 2:20 PM, Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> Please disregard my previous patch and instead attaching updated patch.
>>
>> In my previous patch I used `let` keyword instead of `var` for defining
>> variable, for consistency & backward compatibility I have used `var` in my
>> latest patch.
>>
>
> That seems like an odd way to fix this - we put in ***** Error ***** in
> the backend, then remove it in the front end.
>
> I think it would be better to ensure it's formatted sensibly at the backed
> to begin with.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
Attachment | Content-Type | Size |
---|---|---|
add_testcases_history_tab_v2.diff | text/plain | 1.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2017-09-18 14:50:30 | Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool |
Previous Message | Dave Page | 2017-09-18 13:49:20 | Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool |