| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool |
| Date: | 2017-09-18 13:49:20 |
| Message-ID: | CA+OCxozdyiLFVv2XV1RtpYzN+vryzgDK-nY8cu_xz1J=t8vuGA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi
On Mon, Sep 18, 2017 at 2:20 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> Please disregard my previous patch and instead attaching updated patch.
>
> In my previous patch I used `let` keyword instead of `var` for defining
> variable, for consistency & backward compatibility I have used `var` in my
> latest patch.
>
That seems like an odd way to fix this - we put in ***** Error ***** in the
backend, then remove it in the front end.
I think it would be better to ensure it's formatted sensibly at the backed
to begin with.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Murtuza Zabuawala | 2017-09-18 14:08:19 | Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool |
| Previous Message | Dave Page | 2017-09-18 13:40:14 | Re: Fix for Exception when the server is restarted [RM2713][pgAdmin4] |