From: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: PATCH: to fix jsonb type rendering in runtime (pgAdmin4) |
Date: | 2016-06-30 07:11:40 |
Message-ID: | CAKKotZR-KX5qfLZEVYrAM718kOQTbH1=S_VdRyXFWT4JWHFk-w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi,
PFA updated patch, we have created backgrid jsonb type cell which will work
within browser & runtime.
Regards,
Murtuza
On 29-Jun-2016, at 3:54 pm, Dave Page <dpage(at)pgadmin(dot)org> wrote:
Hi
On Wed, Jun 29, 2016 at 10:32 AM, Murtuza Zabuawala
<murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
Hi,
PFA patch to fix the issue of jsonb type rendering issue in runtime.
RM#1404
I'm not convinced this is a good fix for a couple of reasons:
1) You're only applying the fix if we're running in the runtime. The
runtime uses the Webkit engine just as Safari and Chrome do, so I'm
more inclined to believe this is a version specific issue, rather than
something that is definitely confined to the runtime.
2) What if the user has JSON data in a json field? Or worse, a text field?
I wonder if we could/should mark the contents of all text fields as
CDATA to prevent the browser trying to do anything with them.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment | Content-Type | Size |
---|---|---|
RM_1404_v2.patch | application/octet-stream | 1.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Colin Beckingham | 2016-06-30 07:37:00 | Curious record sorting in pgadmin4 |
Previous Message | Harshal Dhumal | 2016-06-30 06:59:44 | Re: Fix for issue RM1336 [pgadmin4] |