Re: [pgAdmin4][RM#3072] Make pgagent job history rows configurable

On Thu, Apr 5, 2018 at 4:43 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Thu, Apr 5, 2018 at 11:10 AM, Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA patch which allow user to configure how many rows they wish to
>> display for any pgagent jobs on statistics panel.
>>
>
> I think this is essentially good, however, I'm really not happy with the
> preference name and category. In general, I'd suggest that before creating
> patches in the future we should confirm naming etc on the mailing list, as
> I often end up changing wording and then requiring new screenshots etc.
>
​Ok​

>
> In this case, I really don't like that we've added another category, and
> quite a specific one at that. I would suggest we move it to Browser ->
> Properties and name it "Maximum job history rows" with a description of
> "The maximum number of history rows to show on the Statistics tab for
> pgAgent jobs."
>
I'll change it and resend the patch.

>
> Thoughts?
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>