From: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: PATCH: To fix the issue of IntegrityError in server port defination (pgAdmin4) |
Date: | 2016-06-22 09:18:00 |
Message-ID: | CAKKotZQyi4TyD73dhqVCtw2hD3Z9gtCqwJB88WVg9U3QQGJ7XA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Dave,
I checked the code it's already implemented, pgAdmin4.py will upgrade
schema automatically on subsequent run.
Thanks,
Murtuza
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Wed, Jun 22, 2016 at 2:10 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Sure.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Wed, Jun 22, 2016 at 1:35 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> On Wed, Jun 22, 2016 at 7:14 AM, Murtuza Zabuawala
>> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>> > Hi,
>> >
>> > PFA patch to fix the issue in server port check constraint validation
>> which
>> > was not allowing user to save port 65535. (RM#1388)
>> >
>> > We have changed in server table definition hence user has to run
>> "setup.py"
>> > again to fix the issue.
>>
>> Hmm, I think we need to extend pgAdmin4.py to do that upgrade
>> automatically, in the same way that it will automatically run setup if
>> the database doesn't exist. Can we add a version check there, and
>> upgrade if needed?
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Harshal Dhumal | 2016-06-22 10:09:23 | Re: Fix for issue RM1220 and RM 1221 [pgadmin4] |
Previous Message | Murtuza Zabuawala | 2016-06-22 08:40:38 | Re: PATCH: To fix the issue of IntegrityError in server port defination (pgAdmin4) |