From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: PATCH: To fix the issue of IntegrityError in server port defination (pgAdmin4) |
Date: | 2016-06-23 10:44:27 |
Message-ID: | CA+OCxoxr61EP1cOiJ0EULS56TBKNY14Mr28=s6E_3i4_aBy9pA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Ahh, yes - in pgadmin/__init__.py.
Thanks, patch applied.
On Wed, Jun 22, 2016 at 10:18 AM, Murtuza Zabuawala
<murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> I checked the code it's already implemented, pgAdmin4.py will upgrade schema
> automatically on subsequent run.
>
> Thanks,
> Murtuza
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Wed, Jun 22, 2016 at 2:10 PM, Murtuza Zabuawala
> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>> Sure.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Wed, Jun 22, 2016 at 1:35 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>> On Wed, Jun 22, 2016 at 7:14 AM, Murtuza Zabuawala
>>> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>> > Hi,
>>> >
>>> > PFA patch to fix the issue in server port check constraint validation
>>> > which
>>> > was not allowing user to save port 65535. (RM#1388)
>>> >
>>> > We have changed in server table definition hence user has to run
>>> > "setup.py"
>>> > again to fix the issue.
>>>
>>> Hmm, I think we need to extend pgAdmin4.py to do that upgrade
>>> automatically, in the same way that it will automatically run setup if
>>> the database doesn't exist. Can we add a version check there, and
>>> upgrade if needed?
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2016-06-23 10:49:43 | Re: Fix for issue RM1220 and RM 1221 [pgadmin4] |
Previous Message | Dave Page | 2016-06-23 10:43:53 | pgAdmin 4 commit: Fix constraint on server table to allow port 65535 to |