Re: PATCH: Tablespace Node [pgAdmin4]

Hi,

PFA updated patch, I have updated privilege parsing logic.

Regards,
Murtuza

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Thu, Feb 4, 2016 at 1:11 PM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
wrote:

> Thank you Murtuza.
> New patch is working fine with all supported PG version. We should use
> this latest tablespace patch.
>
> Ashesh - Can you please review it ? If It looks good then we should commit
> this patch.
>
> Thanks,
> Neel Patel
>
> On Thu, Feb 4, 2016 at 12:36 PM, Murtuza Zabuawala <
> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>
>> Hi Neel,
>>
>> PFA updated patch for tablespace.
>>
>> Used qtIdent function on role names to handle special characters in role.
>>
>>
>> Regards,
>> Murtuza
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Thu, Feb 4, 2016 at 12:08 PM, Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Neel,
>>>
>>> PFA updated patch.
>>> Added one more condition to check PG version post and pre 9.1.
>>>
>>> Please review it.
>>>
>>> Regards,
>>> Murtuza
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Wed, Feb 3, 2016 at 4:41 PM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
>>> wrote:
>>>
>>>> Hi,
>>>>
>>>> New patch looks good to me. All the features are working fine.
>>>>
>>>> Ashesh - If possible, can you please review it ?. if it looks good then
>>>> you can commit it.
>>>>
>>>> Thanks,
>>>> Neel Patel
>>>>
>>>> On Wed, Feb 3, 2016 at 3:41 PM, Murtuza Zabuawala <
>>>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi Neel,
>>>>>
>>>>> Thanks for reviewing my code, I have fixed the issues mentioned,
>>>>> Please find attached updated patch for table space node.
>>>>>
>>>>> --
>>>>> Regards,
>>>>> Murtuza Zabuawala
>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>> On Wed, Feb 3, 2016 at 2:42 PM, Neel Patel <
>>>>> neel(dot)patel(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>> Hi Murtuza,
>>>>>>
>>>>>> Please find below review comments.
>>>>>>
>>>>>> - "Location" and "Variables" fields are not getting display under
>>>>>> Properties Panel.
>>>>>> - When we remove/add the Variables fields, we are executing query
>>>>>> individually for each parameters. We should execute it in single query as
>>>>>> below.
>>>>>>
>>>>>> e.g.
>>>>>>
>>>>>> *Multiple Query :- *
>>>>>> ALTER TABLESPACE "1 tb"
>>>>>> SET (random_page_cost=123);
>>>>>> ALTER TABLESPACE "1 tb"
>>>>>> SET (seq_page_cost=345);
>>>>>>
>>>>>> *Single Query :- *
>>>>>> ALTER TABLESPACE "1 tb"
>>>>>> SET (random_page_cost=123, seq_page_cost=345);
>>>>>>
>>>>>>
>>>>>> * Multiple Query :- *
>>>>>> ALTER TABLESPACE "1 tb"
>>>>>> RESET (random_page_cost);
>>>>>> ALTER TABLESPACE "1 tb"
>>>>>> RESET (seq_page_cost);
>>>>>>
>>>>>> * Single Query :- *
>>>>>> ALTER TABLESPACE "1 tb"
>>>>>> RESET (random_page_cost, seq_page_cost);
>>>>>>
>>>>>> Other functionalities are working fine. Let us know in case of any
>>>>>> issues.
>>>>>>
>>>>>> Thanks,
>>>>>> Neel Patel
>>>>>>
>>>>>> On Wed, Feb 3, 2016 at 12:57 PM, Murtuza Zabuawala <
>>>>>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> PFA updated patch, Copyright year updated.
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Regards,
>>>>>>> Murtuza Zabuawala
>>>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>
>>>>>>> On Wed, Feb 3, 2016 at 12:22 PM, Murtuza Zabuawala <
>>>>>>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> Please find attach patch for tablespace node for pgAdmin4.
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Regards,
>>>>>>>> Murtuza Zabuawala
>>>>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Sent via pgadmin-hackers mailing list (
>>>>>>> pgadmin-hackers(at)postgresql(dot)org)
>>>>>>> To make changes to your subscription:
>>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>